Fix Scheduling Assigning Incorrect Span Ids #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
added
fix
Mythicaeda
force-pushed
the
fix/scheduling-post-spans
branch
from
02a369c to
6316e7a
Compare
Mythicaeda
force-pushed
the
fix/scheduling-post-spans
branch
from
6316e7a to
4a61f76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug Description: After inserting all the spans from simulation, the scheduler generates a map from its internal span ids to the ids the DB assigned to the spans. The original loop was missing a
++istatement, meaning all of the Scheduler's span ids ended up mapped to the id of the first span posted. This would cause the scheduler to produce incorrect data when it went to update theparent_idfield of the posted child spans.This bug has been fixed by changing the
for-eachloop to afor loop.Verification
A new e2e test was added that schedules a decomposing activity and checks that the post sim results have the correct
parentIds assigned to all the spans.